Use language-specific option for metamodel loading when using emf-model language#2845
Open
Use language-specific option for metamodel loading when using emf-model language#2845
Conversation
…el instance parsing.
…red to parse model instances.
…on contains metamodel files, a warning will be displayed.
Member
Author
|
@robinmaisch, this PR deprecates a few methods of the public API. Is the next release set to be a major one? I could either remove these methods directly or just deprecate them for now. Any preferences? |
51122dd to
d8e99fa
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR replaces the clunky order-based mechanism to ensure metamodel files are loaded before parsing model files. This is done by introducing a language-specific option, which allows specifying one or more paths to
.ecorefiles. As a consequence, theemf-modellanguage no longer requires a submission order. As this is the only language that uses this feature, we can remove it. The corresponding methods in theLanguageinterface are marked as deprecated.While the prototypical
DynamicEmfLanguagewas never available in the CLI, it was available via the API. With this PR it is removed and only a deprecation placeholder remains. TheEmfModelLanguagenow depends onEMFLanguageinstead of theDynamicEmfLanguage. All functionality that is still required is moved to theEmfModelLanguage.Partly solves #576.
Work in progress, tasks left to do:
Languageinterface should be removed now or in a later release.For release notes:
--metamodelCLI option to specify metamodel path(s) when loading the metamodel for EMF-based models.